From: Julia Lawall <julia.lawall@lip6.fr>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-cris-kernel@axis.com,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Mikael Starvik <starvik@axis.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe()
Date: Wed, 4 Oct 2017 22:12:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710042209490.2358@hadrien> (raw)
In-Reply-To: <20171004214432.20833a0ff3b9c8fdced2ebaa@gmail.com>
On Wed, 4 Oct 2017, Alexander Sverdlin wrote:
> Hello Markus,
>
> On Wed, 4 Oct 2017 20:45:14 +0200
> SF Markus Elfring <elfring@users.sourceforge.net> wrote:
>
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
>
> what exactly has the software detected?
> I cannot find, how this error is reported otherwise, it seems
> to me that the message is not that superflous.
>
> The patches 2..4 look to me as an exercise without any practical meaning.
> Indeed, that's not how new code should be posted, but if we start
> rewriting all the legacy code, this will produce huge and completely
> unnecessary patch traffic.
kmalloc etc will produce a backtrace on failure that will provide
essentially the same information.
I don't know what was in the other patches, but the useless assignments to
err in these functions are perhaps worth fixing.
julia
>
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> > arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 --
> > arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 --
> > 2 files changed, 4 deletions(-)
> >
> > diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > index 925a98eb6d68..259aa1f46fbe 100644
> > --- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > @@ -136,8 +136,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
> > /* Allocate memory for MTD device structure and private data */
> > wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
> > if (!wrapper) {
> > - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> > - "device structure.\n");
> > err = -ENOMEM;
> > return NULL;
> > }
> > diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > index 53b56a429dde..1baf16ee74e8 100644
> > --- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > @@ -111,8 +111,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
> > /* Allocate memory for MTD device structure and private data */
> > wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
> > if (!wrapper) {
> > - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> > - "device structure.\n");
> > err = -ENOMEM;
> > return NULL;
> > }
>
> --
> Alexander Sverdlin.
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-10-04 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:43 [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 18:45 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 19:44 ` Alexander Sverdlin
2017-10-04 19:55 ` SF Markus Elfring
2017-10-04 20:12 ` Julia Lawall [this message]
2017-10-04 20:16 ` [PATCH 1/5] " Alexander Sverdlin
2017-10-04 18:46 ` [PATCH 2/5] cris: nand: Improve a size determination " SF Markus Elfring
2017-10-04 18:47 ` [PATCH 3/5] cris: nand: Delete a jump target " SF Markus Elfring
2017-10-04 18:48 ` [PATCH 4/5] cris: nand: Delete an unnecessary local variable " SF Markus Elfring
2017-10-04 20:17 ` Alexander Sverdlin
2017-10-04 18:50 ` [PATCH 5/5] cris: nand: Split a condition check " SF Markus Elfring
2017-10-04 20:26 ` Alexander Sverdlin
2017-10-05 15:31 ` [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710042209490.2358@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alexander.sverdlin@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=elfring@users.sourceforge.net \
--cc=gregory.clement@free-electrons.com \
--cc=jesper.nilsson@axis.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khalasa@piap.pl \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=starvik@axis.com \
--cc=tony@atomide.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®