From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751354AbdJENbo (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Oct 2017 09:31:44 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34056 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751280AbdJENbn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Oct 2017 09:31:43 -0400
Date: Thu, 5 Oct 2017 15:31:30 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v7 4/5] x86/xsave: Make XSAVE check the base CPUID features
 before enabling
In-Reply-To: <20171004234930.5685-5-andi@firstfloor.org>
Message-ID: <alpine.DEB.2.20.1710051527100.2083@nanos>
References: <20171004234930.5685-1-andi@firstfloor.org> <20171004234930.5685-5-andi@firstfloor.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 4 Oct 2017, Andi Kleen wrote:
> +	/*
> +	 * Clear XSAVE features that are disabled in the normal CPUID.
> +	 */
> +	for (i = 0; i < ARRAY_SIZE(xsave_cpuid_features); i++)
> +		if (!boot_cpu_has(xsave_cpuid_features[i]))
> +			xfeatures_mask &= ~BIT(i);

Please add curly braces around this multi line statement.

  https://marc.info/?l=linux-kernel&m=148467980905537&w=2

Thanks,

	tglx