From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbdJEWmM (ORCPT ); Thu, 5 Oct 2017 18:42:12 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:36631 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdJEWmL (ORCPT ); Thu, 5 Oct 2017 18:42:11 -0400 Date: Fri, 6 Oct 2017 00:41:56 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, Andi Kleen , Jonathan McDowell Subject: Re: [PATCH v8 2/5] x86/cpuid: Add generic table for cpuid dependencies In-Reply-To: <20171005215256.25659-3-andi@firstfloor.org> Message-ID: References: <20171005215256.25659-1-andi@firstfloor.org> <20171005215256.25659-3-andi@firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Oct 2017, Andi Kleen wrote: > +/* > + * Table of CPUID features that depend on others. > + * > + * This only includes dependencies that can be usefully disabled, not > + * features part of the base set (like FPU). > + */ > +const static struct cpuid_dep cpuid_deps[] = { > + { X86_FEATURE_XSAVEOPT, X86_FEATURE_XSAVE }, > + { X86_FEATURE_XSAVEC, X86_FEATURE_XSAVE }, > + { X86_FEATURE_XSAVES, X86_FEATURE_XSAVE }, > + { X86_FEATURE_AVX, X86_FEATURE_XSAVE }, > + { X86_FEATURE_AVX512F, X86_FEATURE_XSAVE }, This looks redundant. AVX512F depends on AVX which itself depends on XSAVE. > + { X86_FEATURE_PKU, X86_FEATURE_XSAVE }, > + { X86_FEATURE_MPX, X86_FEATURE_XSAVE }, > + { X86_FEATURE_XGETBV1, X86_FEATURE_XSAVE }, > + { X86_FEATURE_XMM2, X86_FEATURE_XMM }, XMM has no dependency? Thanks, tglx