From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdJHIet (ORCPT ); Sun, 8 Oct 2017 04:34:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:43140 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdJHIer (ORCPT ); Sun, 8 Oct 2017 04:34:47 -0400 Date: Sun, 8 Oct 2017 10:34:25 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling In-Reply-To: <20171007000328.12843-5-andi@firstfloor.org> Message-ID: References: <20171007000328.12843-1-andi@firstfloor.org> <20171007000328.12843-5-andi@firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Oct 2017, Andi Kleen wrote: > From: Andi Kleen > > Before enabling XSAVE, not only check the XSAVE specific CPUID bits, > but also the base CPUID features of the respective XSAVE feature. > This allows to disable individual XSAVE states using the existing > clearcpuid= option, which can be useful for performance testing > and debugging, and also in general avoids inconsistencies. > > v2: > Add curly brackets (Thomas Gleixner) > Signed-off-by: Andi Kleen Reviewed-by: Thomas Gleixner