From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756536AbdJJRbG (ORCPT ); Tue, 10 Oct 2017 13:31:06 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:31591 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756502AbdJJRbC (ORCPT ); Tue, 10 Oct 2017 13:31:02 -0400 X-IronPort-AV: E=Sophos;i="5.43,359,1503352800"; d="scan'208";a="295529458" Date: Tue, 10 Oct 2017 19:31:00 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "Levin, Alexander (Sasha Levin)" cc: Laura Abbott , Mark Rutland , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Catalin Marinas , Will Deacon Subject: Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn() In-Reply-To: <20171010172205.4wtw7x6chq7j2wu3@sasha-lappy> Message-ID: References: <20171006083840.743659740@linuxfoundation.org> <20171006083853.610785662@linuxfoundation.org> <20171006181322.GA19635@leverpostej> <20171007031004.jq322f76fv3do4of@sasha-lappy> <9766830d-c9cc-7f32-9233-d21da37736b4@redhat.com> <20171010172205.4wtw7x6chq7j2wu3@sasha-lappy> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote: > (Cc'ed Julia) > > On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: > >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > >> We are experimenting with using neural network to aid with patch > >> selection for stable kernel trees. There are quite a few commits that > >> were not marked for stable, but are stable material, and we're trying > >> to get them into their appropriate kernel trees. > >> > > > >Apart from the practical which has been covered, I'd be interested > >in hearing about the details of how this works if you can share > >them. > > This work is based on Julia's work > (https://soarsmu.github.io/papers/icse12-patch.pdf) to identify > commits that fix bugs. > > Essentially, my approach to this is to extract as much information as > possbile form the commit, including things such as: > > - How many times a certain word appeared in the message > - Who is the author > - Code metrics > - etc > > In my case, I end up with about 30,000 of these "inputs", and train a > neural network based on whether a given commit was included in a > stable tree or not. > > This approach has a few drawbacks compared to the one Julia > described in her paper: > > - Not every bug fixing commit ends up in stable (some end up in -rc > fixing a bug from the current merge window). > - Same as above, but for commits we miss and fail to add to stable. > - Sometimes commits get added to stable even though they don't follow > the rules at all (security fixes are a simple example). > > But it does seem to be effective at finding bug fixing commits that > should be in stable. > > At this stage we are still trying to figure out what a "bug fixing" > commit really is. For example, an observation we recently made was > that the code metrics actually don't have much weight in determining > whether a commit should be in stable or not. > > As we just started, I'm still experimenting with a few approaches, and > I belive Julia is waiting for a new student to take over this, so we > don't have any big insights to share just yet :) That's a good summary of the current status. Thanks! julia