From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbdJMFwA (ORCPT ); Fri, 13 Oct 2017 01:52:00 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:37728 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdJMFv7 (ORCPT ); Fri, 13 Oct 2017 01:51:59 -0400 X-IronPort-AV: E=Sophos;i="5.43,369,1503352800"; d="scan'208";a="240842275" Date: Fri, 13 Oct 2017 07:51:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Harsha Sharma cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org, jani.nikula@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] drm: Replace kzalloc with kcalloc In-Reply-To: <20171012221758.512-1-harshasharmaiitr@gmail.com> Message-ID: References: <20171012221758.512-1-harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017, Harsha Sharma wrote: > Prefer kcalloc over kzalloc to allocate an array. > This patch fixes checkcpatch issue. > > Signed-off-by: Harsha Sharma > --- > drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- > drivers/gpu/drm/drm_fb_helper.c | 2 +- > drivers/gpu/drm/drm_plane_helper.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index eab36a460638..ceb131637e2f 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -562,12 +562,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set, > * Allocate space for the backup of all (non-pointer) encoder and > * connector data. > */ > - save_encoder_crtcs = kzalloc(dev->mode_config.num_encoder * > + save_encoder_crtcs = kcalloc(dev->mode_config.num_encoder * > sizeof(struct drm_crtc *), GFP_KERNEL); Doesn't kcalloc take 3 arguments? You need to compile the code and check that you have obtained a .o file for the file you modified. julia > if (!save_encoder_crtcs) > return -ENOMEM; > > - save_connector_encoders = kzalloc(dev->mode_config.num_connector * > + save_connector_encoders = kcalloc(dev->mode_config.num_connector * > sizeof(struct drm_encoder *), GFP_KERNEL); > if (!save_connector_encoders) { > kfree(save_encoder_crtcs); > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 1b8f013ffa65..68d197df89fd 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -2266,7 +2266,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper, > if (modes[n] == NULL) > return best_score; > > - crtcs = kzalloc(fb_helper->connector_count * > + crtcs = kcalloc(fb_helper->connector_count * > sizeof(struct drm_fb_helper_crtc *), GFP_KERNEL); > if (!crtcs) > return best_score; > diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c > index 06aee1741e96..74054653530e 100644 > --- a/drivers/gpu/drm/drm_plane_helper.c > +++ b/drivers/gpu/drm/drm_plane_helper.c > @@ -354,7 +354,7 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, > /* Find current connectors for CRTC */ > num_connectors = get_connectors_for_crtc(crtc, NULL, 0); > BUG_ON(num_connectors == 0); > - connector_list = kzalloc(num_connectors * sizeof(*connector_list), > + connector_list = kcalloc(num_connectors * sizeof(*connector_list), > GFP_KERNEL); > if (!connector_list) > return -ENOMEM; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171012221758.512-1-harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >