From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753424AbdJMRkd (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Oct 2017 13:40:33 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48839
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752773AbdJMRkc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2017 13:40:32 -0400
X-IronPort-AV: E=Sophos;i="5.43,371,1503352800"; 
   d="scan'208";a="240936425"
Date: Fri, 13 Oct 2017 19:40:05 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Harsha Sharma <harshasharmaiitr@gmail.com>
cc: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] drm/amd/powerplay: Remove unnecessary
 cast on void pointer
In-Reply-To: <20171013173341.12367-1-harshasharmaiitr@gmail.com>
Message-ID: <alpine.DEB.2.20.1710131938400.6944@hadrien>
References: <20171013173341.12367-1-harshasharmaiitr@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -3400,7 +3400,7 @@ static int smu7_read_sensor(struct pp_hwmgr *hwmgr, int idx,
>  static int smu7_find_dpm_states_clocks_in_dpm_table(struct pp_hwmgr *hwmgr, const void *input)
>  {
>  	const struct phm_set_power_state_input *states =
> -			(const struct phm_set_power_state_input *)input;
> +			input;

Actually, there are some more cleanup opportunities heer and in some other
cases.  There is no need for the newline before input.

julia