From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbdJMVoE (ORCPT ); Fri, 13 Oct 2017 17:44:04 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:42090 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbdJMVoD (ORCPT ); Fri, 13 Oct 2017 17:44:03 -0400 X-IronPort-AV: E=Sophos;i="5.43,372,1503352800"; d="scan'208";a="240946583" Date: Fri, 13 Oct 2017 23:44:01 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Shreeya Patel cc: gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions In-Reply-To: <1507930425-5471-1-git-send-email-shreeya.patel23498@gmail.com> Message-ID: References: <1507930425-5471-1-git-send-email-shreeya.patel23498@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Oct 2017, Shreeya Patel wrote: > Resolve following checkpatch issue: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. > Consider using octal permissions '0444'. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/speakup/speakup_bns.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/speakup_bns.c b/drivers/staging/speakup/speakup_bns.c > index 60bcf0d..402b0fb 100644 > --- a/drivers/staging/speakup/speakup_bns.c > +++ b/drivers/staging/speakup/speakup_bns.c > @@ -120,7 +120,7 @@ static struct spk_synth synth_bns = { > }; > > module_param_named(ser, synth_bns.ser, int, 0444); > -module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO); > +module_param_named(dev, synth_bns.dev_name, charp, 0444); This change is already made. You need to update your staging tree. julia > module_param_named(start, synth_bns.startup, short, 0444); > > MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1507930425-5471-1-git-send-email-shreeya.patel23498%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >