From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752930AbdJPQAZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Oct 2017 12:00:25 -0400
Received: from resqmta-ch2-02v.sys.comcast.net ([69.252.207.34]:38298 "EHLO
        resqmta-ch2-02v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752358AbdJPQAX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Oct 2017 12:00:23 -0400
Date: Mon, 16 Oct 2017 11:00:19 -0500 (CDT)
From: Christopher Lameter <cl@linux.com>
X-X-Sender: cl@nuc-kabylake
To: Michal Hocko <mhocko@kernel.org>
cc: Guy Shattah <sguy@mellanox.com>,
        Mike Kravetz <mike.kravetz@oracle.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Michal Nazarewicz <mina86@mina86.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        Laura Abbott <labbott@redhat.com>, Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [RFC PATCH 3/3] mm/map_contig: Add mmap(MAP_CONTIG) support
In-Reply-To: <20171016123248.csntl6luxgafst6q@dhcp22.suse.cz>
Message-ID: <alpine.DEB.2.20.1710161058470.12436@nuc-kabylake>
References: <20171013084054.me3kxhgbxzgm2lpr@dhcp22.suse.cz> <alpine.DEB.2.20.1710131015420.3949@nuc-kabylake> <20171013152801.nbpk6nluotgbmfrs@dhcp22.suse.cz> <alpine.DEB.2.20.1710131040570.4247@nuc-kabylake> <20171013154747.2jv7rtfqyyagiodn@dhcp22.suse.cz>
 <alpine.DEB.2.20.1710131053450.4400@nuc-kabylake> <20171013161736.htumyr4cskfrjq64@dhcp22.suse.cz> <752b49eb-55c6-5a34-ab41-6e91dd93ea70@mellanox.com> <20171016082456.no6ux63uy2rmj4fe@dhcp22.suse.cz> <0e238c56-c59d-f648-95fc-c8cb56c3652e@mellanox.com>
 <20171016123248.csntl6luxgafst6q@dhcp22.suse.cz>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-CMAE-Envelope: MS4wfELxF+XPG9+hu7wIXlga22sl4ywyTYrMrHhlIlDUl4lpvyeKblizmFNnZbmbEMgZ2kaCxQxxA7Tph7kJJWTWEl6gfcZ7vpQKkErwUUnbN/yZ4qXwzNRR
 bQ4fdWqgZAafLKmZvV51RO5BB5S2mQBZF22zSy3c5nlpdUbygXYRq6Tz4ZfYo72Zca7+tk2Vp5553m3mwfEUxutQ/ZxK5y46/V4arzJWr4gviDjpiiyIIx6H
 qjfEHftHnBwZiQbgcJbAtu29W2Nt1OqoHW+xvfP6NXwfn2YhiD0gKSWv+wjIk4pRWfMlB53T7+sFOVS+gMJ62JBU6igc4e7h7ddFODsPqQBALlBLjq8T1/qC
 OFTbcTpenCFKCnQYiwTwag4glcFhziTlSFEPVK+nS18TDPJ8iStiDE31S7qsAQtNZ3xxHIAL8io4VrVxv9jATunvwo1u+fufemnfUfiKx2cuCB4tJNuaN76m
 d+Xg6F+3c6VtdaT2ey1lfI77wHOsm0x2y1uBM8zNJV70ykwN3flJRVuNJAFevMRljdZw4lvpb0BVqZgfli9rVkeiHF3TemZtez0aOw==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 16 Oct 2017, Michal Hocko wrote:

> But putting that aside. Pinning a lot of memory might cause many
> performance issues and misbehavior. There are still kernel users
> who need high order memory to work properly. On top of that you are
> basically allowing an untrusted user to deplete higher order pages very
> easily unless there is a clever way to enforce per user limit on this.

We already have that issue and have ways to control that by tracking
pinned and mlocked pages as well as limits on their allocations.

> That being said, the list is far from being complete, I am pretty sure
> more would pop out if I thought more thoroughly. The bottom line is that
> while I see many problems to actually implement this feature and
> maintain it longterm I simply do not see a large benefit outside of a
> very specific HW.

There is not much new here in terms of problems. The hardware that
needs this seems to become more and more plentiful. That is why we need a
generic implementation.