From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755159AbdJSOaV (ORCPT ); Thu, 19 Oct 2017 10:30:21 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:33654 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753651AbdJSOaU (ORCPT ); Thu, 19 Oct 2017 10:30:20 -0400 Date: Thu, 19 Oct 2017 16:30:18 +0200 (CEST) From: Thomas Gleixner To: Allen Pais cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, sboyd@codeaurora.org Subject: Re: [PATCH 1/1] time: clocksource: use setup_timer() helper. In-Reply-To: <1505999618-15087-1-git-send-email-allen.lkml@gmail.com> Message-ID: References: <1505999618-15087-1-git-send-email-allen.lkml@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Sep 2017, Allen Pais wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais > --- > kernel/time/clocksource.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c > index 03918a1..5b51d5b 100644 > --- a/kernel/time/clocksource.c > +++ b/kernel/time/clocksource.c > @@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void) > { > if (watchdog_running || !watchdog || list_empty(&watchdog_list)) > return; > - init_timer(&watchdog_timer); > - watchdog_timer.function = clocksource_watchdog; > + setup_timer(&watchdog_timer, clocksource_watchdog, 0UL); We changed this to use the timer_setup() function. Please resend. Thanks, tglx