From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbdJSWZN (ORCPT ); Thu, 19 Oct 2017 18:25:13 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:36071 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954AbdJSWZM (ORCPT ); Thu, 19 Oct 2017 18:25:12 -0400 Date: Fri, 20 Oct 2017 00:25:09 +0200 (CEST) From: Thomas Gleixner To: Daniel Lezcano cc: David Kozub , linux-kernel@vger.kernel.org Subject: Re: [PATCH] clockevents/drivers/cs5535: improve resilience to spurious interrupts In-Reply-To: <0ea5f585-5407-8bcb-1cc9-9a2f3f11b78e@linaro.org> Message-ID: References: <20171019211651.039346004D@linux.fjfi.cvut.cz> <0ea5f585-5407-8bcb-1cc9-9a2f3f11b78e@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Oct 2017, Daniel Lezcano wrote: > On 19/10/2017 22:57, David Kozub wrote: > > This solves a BUG on ALIX 2c3 where mfgpt_tick is called before > > clockevents_config_and_register returns. This caused mfgpt_tick to call a > > null function pointer. > > > > Thanks to Daniel Lezcano and Thomas Gleixner for helping me analyze this > > and suggesting a solution. > > > > Suggested-by: Thomas Gleixner > > Signed-off-by: David Kozub > > --- > > Thank for sending this fix. > > Can you check if the commit 8f9327cbb is the one introducing the > regression ? So we can add the proper tags and propagate the fix to stable. No it's not. - if (cs5535_tick_mode == CLOCK_EVT_MODE_SHUTDOWN) + if (clockevent_state_shutdown(&cs5535_clockevent)) This particular problem of the missing detached state check has been there forever and went unnoticed for whatever reason. Thanks, tglx