From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752365AbdJTONQ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 10:13:16 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:40373 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752301AbdJTONO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 10:13:14 -0400
Date: Fri, 20 Oct 2017 16:13:09 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Kan Liang <kan.liang@intel.com>
cc: Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>, acme@kernel.org,
        eranian@google.com, ak@linux.intel.com
Subject: Re: [PATCH V2 2/4] perf/x86/intel/uncore: inline function to check
 the fixed counter event
In-Reply-To: <1508432137-3984-2-git-send-email-kan.liang@intel.com>
Message-ID: <alpine.DEB.2.20.1710201256420.1765@nanos>
References: <1508432137-3984-1-git-send-email-kan.liang@intel.com> <1508432137-3984-2-git-send-email-kan.liang@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 19 Oct 2017, kan.liang@intel.com wrote:
> From: Kan Liang <Kan.liang@intel.com>
> 
> Remove the special codes in generic uncore_perf_event_update.

What are special codes?

> Introduce inline function to check the fixed counter event.
>  
> +static inline bool uncore_pmc_fixed(int idx)
> +{
> +	return (idx == UNCORE_PMC_IDX_FIXED);

The parentheses are pointless. Please get rid of them.

Thanks,

	tglx