From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753101AbdJTLsd (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 07:48:33 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:39402 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753041AbdJTLsc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 07:48:32 -0400
Date: Fri, 20 Oct 2017 13:48:27 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
cc: Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>, "H. Peter Anvin" <hpa@zytor.com>,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in
 asm/setup.h
In-Reply-To: <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1710201347140.2908@nanos>
References: <20171019105451.2892046-1-arnd@arndb.de> <tip-0f5a0f4f062cc19090a87f9eb8cb79c7c2e4db19@git.kernel.org> <20171020111120.gl3x6hhnkbexdx6i@gmail.com> <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 20 Oct 2017, Arnd Bergmann wrote:
> On Fri, Oct 20, 2017 at 1:11 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >>  #include <asm/iommu_table.h>
> >> +#include <asm/x86_init.h>
> >>
> >>  #include "irq_remapping.h"
> >
> > This breaks the IA64 build:
> >
> >   drivers/iommu/dmar.c:44:26: fatal error: asm/x86_init.h: No such file or directory
> 
> I've sent a fixup to add an #ifdef around it now. Alternatively, we
> could include
> it implicitly in asm/iommu_table.h, which would avoid the #ifdef but
> seem a little
> hacky.

Hrm. Both solutions are ugly. Is there no other way to split stuff up in
those headers (maybe create an extra one).

Thanks,

	tglx