From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932194AbdJXIh2 (ORCPT ); Tue, 24 Oct 2017 04:37:28 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:51152 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbdJXIhZ (ORCPT ); Tue, 24 Oct 2017 04:37:25 -0400 Date: Tue, 24 Oct 2017 10:37:21 +0200 (CEST) From: Thomas Gleixner To: Prasad Sodagudi cc: mingo@kernel.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Clockevents: Always call clockevents_program_event In-Reply-To: <1508832388-30929-1-git-send-email-psodagud@codeaurora.org> Message-ID: References: <664eaf79d594e82c2b3fb736f7c1a50f@codeaurora.org> <1508832388-30929-1-git-send-email-psodagud@codeaurora.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Oct 2017, Prasad Sodagudi wrote: > Currently tick_program_event function is not calling > clockevents_program_event when 'expires == KTIME_MAX', > it is just updating clockevent state to CLOCK_EVT_STATE_ONESHOT_STOPPED. > clockevents_program_event function updates clockevent > device next_event by checking clockevent device state, > so always call clockevents_program_event() from tick_program_event. No. This is fundmentally wrong. If the clockevent is in oneshot stopped mode then you cannot call clockevents_program_event(). There is even a warning in that code which will trigger. Thanks, tglx