From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753975AbdJaWLp (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 18:11:45 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:47362 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753619AbdJaWLo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 18:11:44 -0400
Date: Tue, 31 Oct 2017 23:11:10 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: mingo@kernel.org, dvyukov@google.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org,
        bot+2af19c9e1ffe4d4ee1d16c56ae7580feaee75765@syzkaller.appspotmail.com,
        torvalds@linux-foundation.org, peterz@infradead.org,
        gratian.crisan@ni.com
cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/urgent] futex: Fix more put_pi_state() vs.
 exit_pi_state_list() races
In-Reply-To: <tip-d5f6ac33189af48a0dc011190af5144947a30a76@git.kernel.org>
Message-ID: <alpine.DEB.2.20.1710312310270.1942@nanos>
References: <20171031101853.xpfh72y643kdfhjs@hirez.programming.kicks-ass.net> <tip-d5f6ac33189af48a0dc011190af5144947a30a76@git.kernel.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Oct 2017, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  d5f6ac33189af48a0dc011190af5144947a30a76
> Gitweb:     https://git.kernel.org/tip/d5f6ac33189af48a0dc011190af5144947a30a76
> Author:     Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Tue, 31 Oct 2017 11:18:53 +0100
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 31 Oct 2017 11:54:52 +0100
> 
> futex: Fix more put_pi_state() vs. exit_pi_state_list() races
> 
> Dmitry (through syzbot) reported being able to trigger the WARN in
> get_pi_state() and a use-after-free on:
> 
> 	raw_spin_lock_irq(&pi_state->pi_mutex.wait_lock);
> 
> Both are due to this race:
> 
>   exit_pi_state_list()				put_pi_state()
> 
>   lock(&curr->pi_lock)
>   while() {
> 	pi_state = list_first_entry(head);
> 	hb = hash_futex(&pi_state->key);
> 	unlock(&curr->pi_lock);
> 
> 						dec_and_test(&pi_state->refcount);
> 
> 	lock(&hb->lock)
> 	lock(&pi_state->pi_mutex.wait_lock)	// uaf if pi_state free'd
> 	lock(&curr->pi_lock);
> 
> 	....
> 
> 	unlock(&curr->pi_lock);
> 	get_pi_state();				// WARN; refcount==0
> 
> The problem is we take the reference count too late, and don't allow it
> being 0. Fix it by using inc_not_zero() and simply retrying the loop
> when we fail to get a refcount. In that case put_pi_state() should
> remove the entry from the list.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Gratian Crisan <gratian.crisan@ni.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: dvhart@infradead.org
> Cc: syzbot <bot+2af19c9e1ffe4d4ee1d16c56ae7580feaee75765@syzkaller.appspotmail.com>
> Cc: syzkaller-bugs@googlegroups.com
> Fixes: c74aef2d06a9 ("futex: Fix pi_state->owner serialization")
> Link: http://lkml.kernel.org/r/20171031101853.xpfh72y643kdfhjs@hirez.programming.kicks-ass.net
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

That lacks a stable tag.

Other than that a late:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>