From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934504AbdKGOyv (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Nov 2017 09:54:51 -0500
Received: from resqmta-ch2-11v.sys.comcast.net ([69.252.207.43]:57944 "EHLO
        resqmta-ch2-11v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S934238AbdKGOyt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Nov 2017 09:54:49 -0500
Date: Tue, 7 Nov 2017 08:54:46 -0600 (CST)
From: Christopher Lameter <cl@linux.com>
X-X-Sender: cl@nuc-kabylake
To: Yisheng Xie <xieyisheng1@huawei.com>
cc: Vlastimil Babka <vbabka@suse.cz>, akpm@linux-foundation.org,
        mhocko@suse.com, mingo@kernel.org, rientjes@google.com,
        n-horiguchi@ah.jp.nec.com, salls@cs.ucsb.edu, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, tanxiaojun@huawei.com,
        linux-api@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH RFC v2 4/4] mm/mempolicy: add nodes_empty check in
 SYSC_migrate_pages
In-Reply-To: <a4f1212f-3903-abbc-772a-1ddee6f7f98b@huawei.com>
Message-ID: <alpine.DEB.2.20.1711070851560.18776@nuc-kabylake>
References: <1509099265-30868-1-git-send-email-xieyisheng1@huawei.com> <1509099265-30868-5-git-send-email-xieyisheng1@huawei.com> <dccbeccc-4155-94a8-0e67-b7c28238896d@suse.cz> <bc57f574-92f2-0b69-4717-a1ec7170387c@huawei.com> <d774ecf6-5e7b-e185-85a0-27bf2bcacfb4@suse.cz>
 <alpine.DEB.2.20.1711060926001.9015@nuc-kabylake> <a4f1212f-3903-abbc-772a-1ddee6f7f98b@huawei.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-CMAE-Envelope: MS4wfACrC7NkqcTWsOyWHFNMwro06SyVeM4Xwv3btDxyjCbfd/Y5bZXmv8g+4QIMoYbtuLdlkRPdg6GU3qtL2iCzpGE+WDGuEU0llg/uQgJ76/EUHt0FAaf2
 Su/7AoENDFEHZDEvdwbtMZPKEwGQN3X57OF0AvQYpCJ3fukOiU0zarMgwse4q2j+z8AFReQmWc8dOpQdR8D9ic7Bkx4+/7ayG4TINwPz9AUeQM+C5/89yaoH
 sIStt15bwEKhE/4ogb1Pp808Yvw6h41xPh3pvYs8xNUoEEvwEsZ0cFrRyBQ1or3YJhpl50KTiFeY819rk5i5ayFyc1aHmtPTbcC6W9PntxgXguY7ZeP7buR4
 WWGmFtrSkjbIAFzOM4Wo5MzvpvXdxioO4KhITPDaODWPChnmaydtMZLfy7LPPkmWcpbyirn8v+WHQrZ7eKEJhIKZcMHmkPej1Ql9JPlAQsC64C5xbywH9PQu
 vKLWT9Ou/h7WtDlqcvD04eSZmVCHfP5ep3RZOhBSEh6f2RvjBX/iI1VbuPBOTIH6IwwP7a1bXMcfgxuF
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 7 Nov 2017, Yisheng Xie wrote:

> On 2017/11/6 23:29, Christopher Lameter wrote:
> > On Mon, 6 Nov 2017, Vlastimil Babka wrote:
> >
> >> I'm not sure what exactly is the EPERM intention. Should really the
> >> capability of THIS process override the cpuset restriction of the TARGET
> >> process? Maybe yes. Then, does "insufficient privilege (CAP_SYS_NICE) to
> >
> > CAP_SYS_NICE never overrides cpuset restrictions. The cap can be used to
> > migrate pages that are *also* mapped by other processes (and thus move
> > pages of another process which may have different cpu set restrictions!).
>
> So you means the specified nodes should be a subset of target cpu set, right?

The specified nodes need to be part of the *current* cpu set.

Migrate pages moves the pages of a single process there is no TARGET
process.

Thus thehe *target* nodes need to be a subset of the current cpu set.