From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752183AbdKHLGr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 06:06:47 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:46290 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750760AbdKHLGp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 06:06:45 -0500
Date: Wed, 8 Nov 2017 12:06:40 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Joao Martins <joao.m.martins@oracle.com>
cc: Paolo Bonzini <pbonzini@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Radim Krcmar <rkrcmar@redhat.com>,
        xen-devel <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH v7 2/5] x86/pvclock: add setter for
 pvclock_pvti_cpu0_va
In-Reply-To: <d3957335-f093-9d64-7f82-f4dc97c38268@oracle.com>
Message-ID: <alpine.DEB.2.20.1711081203590.1937@nanos>
References: <20171019133918.18367-1-joao.m.martins@oracle.com> <20171019133918.18367-3-joao.m.martins@oracle.com> <591d9a46-f96e-b3a6-d412-0267f4e412e5@redhat.com> <d3957335-f093-9d64-7f82-f4dc97c38268@oracle.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 7 Nov 2017, Joao Martins wrote:
> On 11/06/2017 04:09 PM, Paolo Bonzini wrote:
> > On 19/10/2017 15:39, Joao Martins wrote:
> >> Right now there is only a pvclock_pvti_cpu0_va() which is defined
> >> on kvmclock since:
> >>
> >> commit dac16fba6fc5
> >> ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap")
> >>
> >> The only user of this interface so far is kvm. This commit adds a
> >> setter function for the pvti page and moves pvclock_pvti_cpu0_va
> >> to pvclock, which is a more generic place to have it; and would
> >> allow other PV clocksources to use it, such as Xen.
> >>
> >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> >> Acked-by: Andy Lutomirski <luto@kernel.org>
> > 
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > IOW, the Xen folks are free to pick up the whole series. :)
> > 
> Thank you!
> 
> I guess only x86 maintainers Ack is left - any comments?

The only nit-pick I have are the convoluted function names:

    pvclock_set_pvti_cpu0_va() pvclock_pvti_cpu0_va()

What on earth does that mean?

Aside of that can you please make it at least symetric, i.e. _set_ and
_get_ ?

Other than that:

      Acked-by: Thomas Gleixner <tglx@linutronix.de>