From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbdKHND4 (ORCPT ); Wed, 8 Nov 2017 08:03:56 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:64670 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdKHNDx (ORCPT ); Wed, 8 Nov 2017 08:03:53 -0500 X-IronPort-AV: E=Sophos;i="5.44,364,1505772000"; d="scan'208";a="243906030" Date: Wed, 8 Nov 2017 21:03:09 +0800 (CST) From: Julia Lawall X-X-Sender: jll@hadrien To: Masahiro Yamada cc: Julia Lawall , Fengguang Wu , "Rafael J . Wysocki" , kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, Linux Kernel Mailing List Subject: Re: [PATCH] Coccinelle: use false positive annotation In-Reply-To: Message-ID: References: <1509234189-26916-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Nov 2017, Masahiro Yamada wrote: > 2017-10-30 12:52 GMT+09:00 Julia Lawall : > > > > > > On Mon, 30 Oct 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >> > >> 2017-10-29 8:43 GMT+09:00 Julia Lawall : > >> > /// is to describe the semantic patch, while //# indicates reasons > >> > for false positives. > >> > > >> > Signed-off-by: Julia Lawall > >> > > >> > --- > >> > scripts/coccinelle/misc/ifcol.cocci | 6 +++--- > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/scripts/coccinelle/misc/ifcol.cocci b/scripts/coccinelle/misc/ifcol.cocci > >> > index d0d00ef..30b248b 100644 > >> > --- a/scripts/coccinelle/misc/ifcol.cocci > >> > +++ b/scripts/coccinelle/misc/ifcol.cocci > >> > @@ -3,9 +3,9 @@ > >> > /// Sometimes, code after an if that is indented is actually intended to be > >> > /// part of the if branch. > >> > /// > >> > -/// This has a high rate of false positives, because Coccinelle's column > >> > -/// calculation does not distinguish between spaces and tabs, so code that > >> > -/// is not visually aligned may be considered to be in the same column. > >> > +//# This has a high rate of false positives, because Coccinelle's column > >> > +//# calculation does not distinguish between spaces and tabs, so code that > >> > +//# is not visually aligned may be considered to be in the same column. > >> > /// > >> > >> Just a nit. > >> > >> The last /// should be turned into // > >> if you want to avoid two blank lines in a series > >> after the semantic patch information. > >> > >> (I can fix it locally if you agree with it and I am supposed to pick up this.) > > > > Thanks for detecting the problem. It would be great if you could pick it > > up, since I haven't heard confirmation from Michal that he will start this > > again. The change seems fine. Thanks for your help. > > > > julia > > > >> > > Fix up the second /// > and applied to linux-kbuild/misc. Thanks! julia