From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753025AbdKIKvP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 05:51:15 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:50547 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752242AbdKIKvO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 05:51:14 -0500
Date: Thu, 9 Nov 2017 11:51:08 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
cc: Dave Hansen <dave.hansen@linux.intel.com>, luto@kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        moritz.lipp@iaik.tugraz.at, daniel.gruss@iaik.tugraz.at,
        michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at,
        torvalds@linux-foundation.org, keescook@google.com, hughd@google.com,
        x86@kernel.org
Subject: Re: [PATCH 02/30] x86, tlb: make CR4-based TLB flushes more robust
In-Reply-To: <20171109104813.h67cts3mmr5zh4kd@pd.tnic>
Message-ID: <alpine.DEB.2.20.1711091149500.1839@nanos>
References: <20171108194646.907A1942@viggo.jf.intel.com> <20171108194649.61C7A485@viggo.jf.intel.com> <20171109104813.h67cts3mmr5zh4kd@pd.tnic>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Nov 2017, Borislav Petkov wrote:
> On Wed, Nov 08, 2017 at 11:46:49AM -0800, Dave Hansen wrote:
> > +	/* Put original CR4 value back: */
> >  	native_write_cr4(cr4);
> >  }
> 
> Btw, Andy, we read the CR4 shadow in that function but we don't update
> it. Why?

Because its the same as before.

> > +   /* Put original CR4 value back: */
> >     native_write_cr4(cr4);

Thanks,

	tglx