From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867AbdKMOLx (ORCPT ); Mon, 13 Nov 2017 09:11:53 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:33573 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdKMOLt (ORCPT ); Mon, 13 Nov 2017 09:11:49 -0500 Date: Mon, 13 Nov 2017 15:11:45 +0100 (CET) From: Thomas Gleixner To: Andrew Lunn cc: Lucas Stach , Chris Healy , linux-kernel@vger.kernel.org Subject: Re: lockdep annotation for desc->request_mutex In-Reply-To: <20171109180059.GG13277@lunn.ch> Message-ID: References: <20171109180059.GG13277@lunn.ch> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew, On Thu, 9 Nov 2017, Andrew Lunn wrote: > Hi Thomas > > I'm been given reports of a new lockdep splat while testing > 4.14-rc8. It appears to be a false positive, due to missing lockdep > annotation on desc->request_mutex. The driver is using two different > interrupt descriptors via different paths. But without annotation, > lockdep thinks it is the same mutex. Hmm. > Do you have patches adding a lockdep class for desc->request_mutex? No. I think we should extend irq_set_lockdep_class() and hand in two keys then. Thanks, tglx