From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080AbdKMPKK (ORCPT ); Mon, 13 Nov 2017 10:10:10 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:33774 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbdKMPKJ (ORCPT ); Mon, 13 Nov 2017 10:10:09 -0500 Date: Mon, 13 Nov 2017 16:10:06 +0100 (CET) From: Thomas Gleixner To: Daniel Lezcano cc: Sudeep Holla , Arnd Bergmann , Benjamin Gaignard , LKML Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init In-Reply-To: <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org> Message-ID: References: <20171106133450.482858-1-arnd@arndb.de> <20171113101107.GA9084@e107155-lin> <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Nov 2017, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: > > Agreed, may be if we add users which is called from init functions, the > > warning should disappear. Also as tglx suggested, we could rename if it's > > just used from init function error/exit paths. > > The drivers are not compiled as module AFAICT, the function will be > called in the init error path. Ok, if the consensus is that this is used for common cleanup in __init error handling, then please can someone submit a new version of this which renames the function to something like timer_of_cleanup() and add the __init annotation to it? And while at it please add a kernel doc comment to that effect. Thanks, tglx