From: Thomas Gleixner <tglx@linutronix.de>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: mingo@kernel.org, fweisbec@gmail.com,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
Joe Jin <joe.jin@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tick/broadcast: Remove redundant code in tick_check_new_device()
Date: Mon, 13 Nov 2017 17:54:34 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711131738140.1851@nanos> (raw)
In-Reply-To: <35b094f6-70e0-49f2-803a-3333d7ee2524@default>
On Wed, 8 Nov 2017, Zhenzhong Duan wrote:
> There is no way a timer used as broadcast clockevent device is also used as
> percpu tick clockevent device currently.
Correct.
> It's better to put related code in tick_install_broadcast_device(), but I feel
> it's harmless to give it back to the clockevents layer. Pls correct me if I'm
> wrong.
You already established, that it _cannot_ be the broadcast device and the
per cpu device at the same time. So that condition can never be true. What
do you want to put into tick_install_broadcast_device()? This second
paragraph doesn't make sense, unless I'm missing something.
Thanks,
tglx
next prev parent reply other threads:[~2017-11-13 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 4:54 Zhenzhong Duan
2017-11-13 16:54 ` Thomas Gleixner [this message]
2017-11-14 3:29 ` Zhenzhong Duan
2017-11-14 11:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711131738140.1851@nanos \
--to=tglx@linutronix.de \
--cc=fweisbec@gmail.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srinivas.eeda@oracle.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®