From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755812AbdKMVDr (ORCPT ); Mon, 13 Nov 2017 16:03:47 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:35104 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbdKMVDq (ORCPT ); Mon, 13 Nov 2017 16:03:46 -0500 Date: Mon, 13 Nov 2017 22:03:42 +0100 (CET) From: Thomas Gleixner To: Deepa Dinamani cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org Subject: Re: [PATCH 4/9] posix-clocks: Enable compat syscalls always In-Reply-To: <20171110224259.15930-5-deepa.kernel@gmail.com> Message-ID: References: <20171110224259.15930-1-deepa.kernel@gmail.com> <20171110224259.15930-5-deepa.kernel@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Nov 2017, Deepa Dinamani wrote: > > -#ifdef CONFIG_COMPAT > - > COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp, > struct compat_timespec __user *, rmtp) > { > @@ -1574,7 +1572,6 @@ COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp, > current->restart_block.nanosleep.compat_rmtp = rmtp; > return hrtimer_nanosleep(&tu, HRTIMER_MODE_REL, CLOCK_MONOTONIC); > } > -#endif So if I'm not missing something important this will make the compat syscall define available even for CONFIG_X86_64=y CONFIG_IA32_EMULATION=n CONFIG_X86_X32=n which is wrong because in that configuration we don't have any 32bit executable support. So why would we need a compat syscall in that case? Thanks, tglx