From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754612AbdKNJy7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 04:54:59 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:47504 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753449AbdKNJyu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 04:54:50 -0500
X-IronPort-AV: E=Sophos;i="5.44,393,1505772000"; 
   d="scan'208";a="300698289"
Date: Tue, 14 Nov 2017 10:54:44 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Masahiro Yamada <yamada.masahiro@socionext.com>
cc: linux-kbuild@vger.kernel.org, cocci@systeme.lip6.fr,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Michal Marek <michal.lkml@markovi.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help
 to top Makefile
In-Reply-To: <1510652841-6779-1-git-send-email-yamada.masahiro@socionext.com>
Message-ID: <alpine.DEB.2.20.1711141054290.2874@hadrien>
References: <1510652841-6779-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tue, 14 Nov 2017, Masahiro Yamada wrote:

> I do not think it is helpful to have a separate file just for the
> coccicheck help message.  Merge scripts/Makefile.help into the
> top-level Makefile.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Thanks!

> ---
>
>  Makefile              | 2 +-
>  scripts/Makefile.help | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
>  delete mode 100644 scripts/Makefile.help
>
> diff --git a/Makefile b/Makefile
> index f060f94..3b7d477 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1388,7 +1388,7 @@ help:
>  	@echo  '  export_report   - List the usages of all exported symbols'
>  	@echo  '  headers_check   - Sanity check on exported headers'
>  	@echo  '  headerdep       - Detect inclusion cycles in headers'
> -	@$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> +	@echo  '  coccicheck      - Check with Coccinelle'
>  	@echo  ''
>  	@echo  'Kernel selftest:'
>  	@echo  '  kselftest       - Build and run kernel selftest (run as root)'
> diff --git a/scripts/Makefile.help b/scripts/Makefile.help
> deleted file mode 100644
> index d03608f..0000000
> --- a/scripts/Makefile.help
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -
> -checker-help:
> -	@echo  '  coccicheck      - Check with Coccinelle.'
> --
> 2.7.4
>
>