From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757178AbdKNXW5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 18:22:57 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:39602 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756551AbdKNXWt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 18:22:49 -0500
Date: Wed, 15 Nov 2017 00:22:45 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: Mark Salyzyn <salyzyn@android.com>, Petr Mladek <pmladek@suse.com>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Prarit Bhargava <prarit@redhat.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [GIT pull] printk updates for 4.15
In-Reply-To: <CA+55aFz-VvPBoW0RvDW4eN5YhwaUzcMvsYzrqEC41QdfOdiF4Q@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711150022000.2221@nanos>
References: <alpine.DEB.2.20.1711131023170.1851@nanos> <CA+55aFwUfA__6MgMgjENnx+_RYY2ZOOLiSx2ea1AvYhSZN+78A@mail.gmail.com> <20171114100336.uil744pxmbsawq63@pathway.suse.cz> <CA+55aFzLH9crdMtUFkD-PtNGuxu_fsG5GH2ACni69ug9iM=09g@mail.gmail.com>
 <alpine.DEB.2.20.1711142044110.2221@nanos> <CA+55aFwNo9CDzuDWue7QJYd_iip4bgEqduVjNAHjxwdxjiur1g@mail.gmail.com> <7d23f705-1479-7874-7918-f2af9ec02c86@android.com> <CA+55aFzzvBD4_WYm-5Bm7TeRGR8nNu1oz0oWNcRNmTNJm=M4Lw@mail.gmail.com>
 <7f0e0165-2b22-f2cf-ce6e-8db3d7325973@android.com> <CA+55aFxa8gtN54KD48mf7_mNnMdiduhJ5GTKmJmf_VgLkSZ2fQ@mail.gmail.com> <alpine.DEB.2.20.1711142341130.2221@nanos> <CA+55aFzM+UK=X163YHqAjYnt2ne0oBq9AT1+Ct8XoxbwOmH4rA@mail.gmail.com> <alpine.DEB.2.20.1711150001190.2221@nanos>
 <CA+55aFz-VvPBoW0RvDW4eN5YhwaUzcMvsYzrqEC41QdfOdiF4Q@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Nov 2017, Linus Torvalds wrote:
> On Tue, Nov 14, 2017 at 3:04 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > True. I already replaced all of them except this one:
> >
> > @@ -1022,6 +1026,7 @@ void log_buf_vmcoreinfo_setup(void)
> >          */
> >         VMCOREINFO_STRUCT_SIZE(printk_log);
> >         VMCOREINFO_OFFSET(printk_log, ts_nsec);
> > +       VMCOREINFO_OFFSET(printk_log, ts);
> >         VMCOREINFO_OFFSET(printk_log, len);
> >         VMCOREINFO_OFFSET(printk_log, text_len);
> >         VMCOREINFO_OFFSET(printk_log, dict_len);
> >
> > If I remove ts_nsec completely, then the VMCORE info changes and that would
> > break existing tools because they search for ts_nsec and fail....
> 
> Dear god, that's nasty.
> 
> I agree that the vmcore info name probably needs to be retained, but
> maybe we could just do that with
> 
> #define VMCOREINFO_FIELD_AND_OFFSET(name, field, offset) \
>         vmcoreinfo_append_str("OFFSET(%s.%s)=%lu\n", name, field, offset)
> 
> and then do
> 
>   #define VMCOREINFO_OFFSET(name, field) \
>         VMCOREINFO_FIELD_AND_OFFSET(#name, #field, \
>                 (unsigned long)offsetof(struct name, offset))
> 
> and for that ts_nsec you can then do
> 
>    /* ts.mono used to be called "ts_nsec" */
>    VMCOREINFO_FIELD_AND_OFFSET("printk_log", "ts_nsec",
>         (unsigned long)offsetof(struct printk_log, ts.mono))
> 
> or something.
> 
> And I may obviously have messed that all up, I wrote it all in the
> email client, so it's more pseudo-code than anything else.
> 
> But it looks pretty straight-forward conceptually, and would make it
> pretty clear what is going on, no?

That should work. I'll try that tomorrow with brain awake.

Thanks,

	tglx