From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757822AbdKOOvV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 09:51:21 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40662
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1756793AbdKOOvM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 09:51:12 -0500
X-IronPort-AV: E=Sophos;i="5.44,399,1505772000"; 
   d="scan'208";a="244734672"
Date: Wed, 15 Nov 2017 15:51:04 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Masahiro Yamada <yamada.masahiro@socionext.com>
cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nicolas Palix <nicolas.palix@imag.fr>, cocci@systeme.lip6.fr
Subject: Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve
 efficiency
In-Reply-To: <CAK7LNASTP80Yp66UP=oBM7evXD3Pg1GXJ_P9+m=dGp=mAUbe4Q@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711151550190.3647@hadrien>
References: <alpine.DEB.2.20.1711121704350.10412@hadrien> <CAK7LNASTP80Yp66UP=oBM7evXD3Pg1GXJ_P9+m=dGp=mAUbe4Q@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Wed, 15 Nov 2017, Masahiro Yamada wrote:

> Hi Julia,
>
>
> 2017-11-13 1:08 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> > An initial rule just matching a function call makes it possible to focus
> > on one all at a time, which improves performance in complex functions with
> > multiple locking calls.  Using a constraint expression lock2 != pre.lock1;
> > makes it possible to eliminate the double matching of the lock, lock
> > sequence.
> >
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
>
> If I apply this patch, locks/flags.cocci does not work for me.
>
>
> $ make coccicheck COCCI=scripts/coccinelle/locks/flags.cocci
> MODE=report  DEBUG_FILE=log.txt
>
> Please check for false positives in the output before submitting a patch.
> When using "patch" mode, carefully review the patch before submitting it.
>
> 607 610
> coccicheck failed
> $ cat  log.txt
> /usr/bin/spatch -D report --no-show-diff --very-quiet --cocci-file
> scripts/coccinelle/locks/flags.cocci --no-includes --include-headers
> --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I
> ./include -I ./arch/x86/include/uapi -I
> ./arch/x86/include/generated/uapi -I ./include/uapi -I
> ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 8
> --chunksize 1
> Fatal error: exception Failure("meta: parse error: \n = File
> \"scripts/coccinelle/locks/flags.cocci\", line 29, column 20,  charpos
> = 607\n    around = 'pre', whole content = expression lock2 !=
> pre.lock1;\n")
>
>
>
> Could you check it?

What version of Coccinelle do you have?

But the way, Thierry Martinez should get in touch with you shortly about
the badzero problem.

julia