From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758477AbdKPHbe (ORCPT ); Thu, 16 Nov 2017 02:31:34 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:38269 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753887AbdKPHb0 (ORCPT ); Thu, 16 Nov 2017 02:31:26 -0500 X-IronPort-AV: E=Sophos;i="5.44,402,1505772000"; d="scan'208";a="301013520" Date: Thu, 16 Nov 2017 08:31:24 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Masahiro Yamada , Linux Kernel Mailing List , Michal Marek , Nicolas Palix , cocci@systeme.lip6.fr Subject: Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency In-Reply-To: <1510783347.25299.2.camel@perches.com> Message-ID: References: <1510783347.25299.2.camel@perches.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Nov 2017, Joe Perches wrote: > On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote: > > What version of Coccinelle do you have? > > > I tried 1.0.4 and 1.0.6, > > > but both failed. > > For me, it also fails for 1.0.6. It should be OK for 1.0.7. > > Then likely this patch should not be applied or > some form of local version checking should be done > in the script itself. > > Scripts that use various tools are subject to > language versioning requirements. > > For instance, there are many things that are > possible with later versions of perl, but are not > done for various scripts because many distributions > do not ship with the latest versions. It will say coccicheck failed if it is not compatible with the version of Coccinelle. But it shouldn't break anything. We should put that it requires 1.0.7, but I don't know if that is actually checked, or just provided as documentation for the reader. julia