From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1423090AbdKQW7z (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 17:59:55 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:53065 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966853AbdKQW7s (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 17:59:48 -0500
Date: Fri, 17 Nov 2017 23:59:42 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
cc: Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        jailhouse-dev@googlegroups.com
Subject: Re: [PATCH 06/10] x86: jailhouse: Avoid access of unsupported platform
 resources
In-Reply-To: <alpine.DEB.2.20.1711172350130.2186@nanos>
Message-ID: <alpine.DEB.2.20.1711172358230.2186@nanos>
References: <cover.1510817211.git.jan.kiszka@siemens.com> <a7b99fc10c96749b94004aa2ee314aa9ba37fa30.1510817211.git.jan.kiszka@siemens.com> <alpine.DEB.2.20.1711172350130.2186@nanos>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 17 Nov 2017, Thomas Gleixner wrote:
> On Thu, 16 Nov 2017, Jan Kiszka wrote:
> 
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > We don't have CMOS access, thus we can't set the warm-reset vectors in
> 
> s/We/A jailhouse cell/ or s/We/A jailhouse guest/
> 
> > do_boot_cpu. There is no RTC, thus also no wall clock. Furthermore,
> > there are no ISA IRQs and no PIC. So fill the platform callbacks
> > accordingly.
>   
> > +static void jailhouse_get_wallclock(struct timespec *now)
> > +{
> > +	memset(now, 0, sizeof(*now));
> > +}
> 
> > @@ -1006,7 +1007,8 @@ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle,
> >  	 * the targeted processor.
> >  	 */
> >  
> > -	if (get_uv_system_type() != UV_NON_UNIQUE_APIC) {
> > +	if (get_uv_system_type() != UV_NON_UNIQUE_APIC &&
> > +	    !jailhouse_paravirt()) {
> >  
> >  		pr_debug("Setting warm reset code and vector.\n");
> 
> Adding more here might justify a function pointer in x86_platform_ops. Not
> sure though, but we have an increasing amount of xen()/kvm()/whatever
> conditionals popping up all over the place. And now you add jailhouse()
> ones :)

Actually we don't want a function pointer as we would need two. A simple
flag would be sufficient.

Thanks,

	tglx