From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdKTWn3 (ORCPT ); Mon, 20 Nov 2017 17:43:29 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:60703 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbdKTWn2 (ORCPT ); Mon, 20 Nov 2017 17:43:28 -0500 Date: Mon, 20 Nov 2017 23:43:22 +0100 (CET) From: Thomas Gleixner To: Jarkko Sakkinen cc: Peter Zijlstra , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 08/11] intel_sgx: in-kernel launch enclave In-Reply-To: <20171120222535.7yqibz2rxltwvip7@linux.intel.com> Message-ID: References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-9-jarkko.sakkinen@linux.intel.com> <20171115115006.p2wkvfuojwgg26br@hirez.programming.kicks-ass.net> <20171120222535.7yqibz2rxltwvip7@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Nov 2017, Jarkko Sakkinen wrote: > On Wed, Nov 15, 2017 at 12:50:06PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 13, 2017 at 09:45:25PM +0200, Jarkko Sakkinen wrote: > > > TinyCrypt (https://github.com/01org/tinycrypt) is used as AES > > > implementation, which is not timing resistant. Eventually this needs to > > > be replaced with AES-NI based implementation that could be either > > > > > - re-use existing AES-NI code in the kernel > > > > This. That is an absolute must. We're not going to merge custom AES > > implementations. > > I'll post v6 update without update to this in order to get otherwise > improved version out and work on it for v7. > > My initial idea to sort this out would be to try to compile > > arch/x86/crypto/aesni-intel_asm.S > > as part of the enclave binary and use it to run AES-256. No. The kernel has a crypto API. Thanks, tglx