From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753451AbdKXLdI (ORCPT ); Fri, 24 Nov 2017 06:33:08 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58446 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239AbdKXLdH (ORCPT ); Fri, 24 Nov 2017 06:33:07 -0500 X-IronPort-AV: E=Sophos;i="5.44,447,1505772000"; d="scan'208";a="245882017" Date: Fri, 24 Nov 2017 12:33:04 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Adam Thomson cc: SF Markus Elfring , "alsa-devel@alsa-project.org" , Support Opensource , Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , LKML , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata() In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1B116F@SW-EX-MBX01.diasemi.com> Message-ID: References: <6dc71b14-4c14-82f6-9dad-92bfa9854de2@users.sourceforge.net> <2E89032DDAA8B9408CB92943514A0337014C1B116F@SW-EX-MBX01.diasemi.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-640844049-1511523185=:3316" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8323329-640844049-1511523185=:3316 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 24 Nov 2017, Adam Thomson wrote: > On 23 November 2017 17:33, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Thu, 23 Nov 2017 17:56:54 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > I'm not sure this is an extra message. We don't return -ENOMEM as a result of > this operation and probe won't fail on this. So does devm_kzalloc() print error > messages? Unless there is NO WARN, a backtrace will be generated in the out of memory case. julia > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > sound/soc/codecs/da7213.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c > > index 41d9b1da27c2..d1b77a0e3b74 100644 > > --- a/sound/soc/codecs/da7213.c > > +++ b/sound/soc/codecs/da7213.c > > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data > > u32 fw_val32; > > > > pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL); > > - if (!pdata) { > > - dev_warn(codec->dev, "Failed to allocate memory for pdata\n"); > > + if (!pdata) > > return NULL; > > - } > > > > if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0) > > pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32); > > -- > > 2.15.0 > N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*jg????????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G???????:+v???w???? --8323329-640844049-1511523185=:3316--