From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751883AbdKYVk4 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 25 Nov 2017 16:40:56 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:50617 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751753AbdKYVkz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Nov 2017 16:40:55 -0500
Date: Sat, 25 Nov 2017 22:40:52 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>
cc: linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 28/43] x86/mm/kaiser: Map cpu entry area
In-Reply-To: <20171124172411.19476-29-mingo@kernel.org>
Message-ID: <alpine.DEB.2.20.1711252234210.2316@nanos>
References: <20171124172411.19476-1-mingo@kernel.org> <20171124172411.19476-29-mingo@kernel.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 24 Nov 2017, Ingo Molnar wrote:
> +void kaiser_add_mapping_cpu_entry(int cpu)
> +{
> +	kaiser_add_user_map_early(get_cpu_gdt_ro(cpu), PAGE_SIZE,
> +				  __PAGE_KERNEL_RO);
> +
> +	/* includes the entry stack */
> +	kaiser_add_user_map_early(&get_cpu_entry_area(cpu)->tss,
> +				  sizeof(get_cpu_entry_area(cpu)->tss),
> +				  __PAGE_KERNEL | _PAGE_GLOBAL);
> +
> +	/* Entry code, so needs to be EXEC */
> +	kaiser_add_user_map_early(&get_cpu_entry_area(cpu)->entry_trampoline,
> +				  sizeof(get_cpu_entry_area(cpu)->entry_trampoline),
> +				  __PAGE_KERNEL_EXEC | _PAGE_GLOBAL);

This creates a RWX mapping and wants to be __PAGE_KERNEL_RX!

Whats weird is that I saw dump_walk_pgd_level_checkwx() complain once about
that, but on the next boot it failed to detect it for whatever reason. This
needs further investigation.

Thanks,

	tglx