From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbdKZRJw (ORCPT ); Sun, 26 Nov 2017 12:09:52 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41315 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdKZRJv (ORCPT ); Sun, 26 Nov 2017 12:09:51 -0500 X-IronPort-AV: E=Sophos;i="5.44,459,1505772000"; d="scan'208";a="302546404" Date: Sun, 26 Nov 2017 18:09:47 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Logan Gunthorpe cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft , Joe Perches Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line In-Reply-To: <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> Message-ID: References: <20171126054037.9743-1-logang@deltatee.com> <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 25/11/17 10:51 PM, Julia Lawall wrote: > > I don't understand at all the second sentence. Are you staying with the > > same call, or moving on to other calls? Also, it would be the call that > > is split over multiple lines, not the function split over multiple lines. > > Yes, you are correct it should be "call" instead of "function". > > > I think this would have been much easier with Cocccinelle where the code > > is parsed and the control-flow graph is available to see whether there is > > a pr_cont afterwards. But if it works, then it is surely good enough. > > I don't disagree at all. However, to my knowledge, not a lot of kernel > developers run a set of coccinelle scripts on their change sets. The > point is to catch these mistakes before the patch is submitted. I don't know. In any case, a Coccinelle script would get run by the 0-day build testing service, which checks lots of trees. Perhaps both are useful, since Joe had some conerns about the amount of relevant context available in a patch. julia