From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbdK0GLa (ORCPT ); Mon, 27 Nov 2017 01:11:30 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:32359 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbdK0GL3 (ORCPT ); Mon, 27 Nov 2017 01:11:29 -0500 X-IronPort-AV: E=Sophos;i="5.44,463,1505772000"; d="scan'208";a="302580613" Date: Mon, 27 Nov 2017 07:11:28 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Logan Gunthorpe cc: Joe Perches , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line In-Reply-To: <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> Message-ID: References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 03:29 PM, Joe Perches wrote: > > This proposal has a very high false positive rate. > > The only actual false positive you've pointed out is the one that is > just incorrect in the wrong way (the author should have used a KERN_CONT > but did not). I could easily do something similar to what Julia proposes > and produce a different warning if the string ends in a space. I don't have a different warning if the string ends in a space. I have a different warning when one possible control-flow path is fine and another control-flow path is not. The space thing relates to guessing whether some other printing API function needs a newline or not. julia > But I > don't see any bullet proof way for any script to deduce what the author > actually meant. > > > Keep at it though. > > Maybe something useful will be produced with more effort. > > Unless there's more actually constructive criticism I don't think I'll > be getting any further with this. > > Logan >