From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751285AbdK0GeI (ORCPT ); Mon, 27 Nov 2017 01:34:08 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:12914 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdK0GeH (ORCPT ); Mon, 27 Nov 2017 01:34:07 -0500 X-IronPort-AV: E=Sophos;i="5.44,463,1505772000"; d="scan'208";a="302583734" Date: Mon, 27 Nov 2017 07:34:06 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Logan Gunthorpe cc: Joe Perches , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line In-Reply-To: Message-ID: References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Nov 2017, Logan Gunthorpe wrote: > > > On 26/11/17 11:11 PM, Julia Lawall wrote: > > I don't have a different warning if the string ends in a space. I have a > > different warning when one possible control-flow path is fine and another > > control-flow path is not. The space thing relates to guessing whether > > some other printing API function needs a newline or not. > > Understood. For checkpatch, there only is warnings (of various types) > and I was referring to the guessing you mentioned. So if we see that a > call has no new line and the following one isn't a KERN_CONT, then based > on whether there's a space or not we potentially could have one of two > warnings: > > WARNING: Log messages should end in a new line (\n) > > or > > WARNING: Given that your log message ends in a space and not a new line, > did you maybe mean to put a KERN_CONT or pr_cont somewhere in there?? By > the way, though, KERN_CONT use is discouraged and will create its own > warning when you fix it. It would probably be better not to mention the KERN_CONT possibility at all. julia