From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdK0Gmv (ORCPT ); Mon, 27 Nov 2017 01:42:51 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:29049 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdK0Gmu (ORCPT ); Mon, 27 Nov 2017 01:42:50 -0500 X-IronPort-AV: E=Sophos;i="5.44,463,1505772000"; d="scan'208";a="246065550" Date: Mon, 27 Nov 2017 07:42:48 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line In-Reply-To: Message-ID: References: <20171126054037.9743-1-logang@deltatee.com> <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com> <1511746526.20482.38.camel@perches.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Nov 2017, Julia Lawall wrote: > > > On Sun, 26 Nov 2017, Joe Perches wrote: > > > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote: > > > I just assume that a printk that has no KERN_ is adding a > > > newline, which is my understanding of Joe's comment. > > > > More precisely: > > > > Any printk without an initial KERN_CONT prepends a newline > > if the last printk content char emitted that is not part > > of a printk timestamp/header was not a newline. > > Ah, I misunderstood. I thought it was any printk that has no KERN > indicator at all. That I can fix. Although I guess that in that case the whole exercise is pointless? Because every print will at runtime be followed by another print, which will add either the newline or a continuation. julia