From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751355AbdK0IwT (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 03:52:19 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:33538
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751138AbdK0IwS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 03:52:18 -0500
X-IronPort-AV: E=Sophos;i="5.44,463,1505772000"; 
   d="scan'208";a="246084896"
Date: Mon, 27 Nov 2017 09:52:15 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Joe Perches <joe@perches.com>
cc: Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line
In-Reply-To: <1511771322.32426.1.camel@perches.com>
Message-ID: <alpine.DEB.2.20.1711270951450.3445@hadrien>
References: <20171126054037.9743-1-logang@deltatee.com>  <alpine.DEB.2.20.1711260648130.2387@hadrien>  <1511676085.20482.18.camel@perches.com>  <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com>  <1511735382.20482.27.camel@perches.com> 
 <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com>  <alpine.DEB.2.20.1711270709390.2369@hadrien>  <ec39f4f5-cfab-a184-0f27-7f0172e2984f@deltatee.com>  <alpine.DEB.2.20.1711270732550.2369@hadrien>  <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com>
 <1511771322.32426.1.camel@perches.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Mon, 27 Nov 2017, Joe Perches wrote:

> On Sun, 2017-11-26 at 23:40 -0700, Logan Gunthorpe wrote:
> >
> > On 26/11/17 11:34 PM, Julia Lawall wrote:
> > > It would probably be better not to mention the KERN_CONT possibility at
> > > all.
> >
> > Oh? I don't disagree... but what are we supposed to do in these cases?
> > The way v2 of my patch works it just says that there is a missing new
> > line. But Joe calls that a false positive. So if we can't report that
> > it's missing a new line and we can't say it looks like it needs a
> > KERN_CONT, then what can we do? The case is obviously wrong in some way
> > or another so we probably shouldn't just ignore it.

I meant why not only suggest pr_cont?

julia

>
> checkpatch already reports printks without KERN_<level>
>
> # printk should use KERN_* levels
> 		if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
> 			WARN("PRINTK_WITHOUT_KERN_LEVEL",
> 			     "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
> 		}
>
>