From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753954AbdK0RcT (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 12:32:19 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:56917 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752803AbdK0RcS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 12:32:18 -0500
Date: Mon, 27 Nov 2017 18:32:11 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 10/24] x86/mm/kaiser: Map the entry stack variables
In-Reply-To: <20171127172216.vd7ompgabf2bol76@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1711271831250.1799@nanos>
References: <20171127104923.14378-1-mingo@kernel.org> <20171127104923.14378-11-mingo@kernel.org> <20171127172216.vd7ompgabf2bol76@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Nov 2017, Peter Zijlstra wrote:

> On Mon, Nov 27, 2017 at 11:49:09AM +0100, Ingo Molnar wrote:
> > diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
> > index 157f81816915..631e229ab428 100644
> > --- a/arch/x86/kernel/process_64.c
> > +++ b/arch/x86/kernel/process_64.c
> > @@ -59,7 +59,7 @@
> >  #include <asm/unistd_32_ia32.h>
> >  #endif
> >  
> > -__visible DEFINE_PER_CPU(unsigned long, rsp_scratch);
> > +__visible DEFINE_PER_CPU_USER_MAPPED(unsigned long, rsp_scratch);
> >  
> >  /* Prints also some state that isn't saved in the pt_regs */
> >  void __show_regs(struct pt_regs *regs, int all)
> 
> Do we still need this one? It appears to me we'll never actually execute
> that part of entry_SYSCALL_64 anymore, due to
> entry_SYSCALL_64_trampoline.

Unless we use entry_SYSCALL_64 when kaiser is disabled at boottime

Thanks,

	tglx