From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs
Date: Tue, 28 Nov 2017 21:08:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711282108000.2222@nanos> (raw)
In-Reply-To: <CA+55aFw5DAB6qZu4fmDTvhU-wB4zNhUGuBBdBzMnh5d=ybBj-g@mail.gmail.com>
On Tue, 28 Nov 2017, Linus Torvalds wrote:
> On Tue, Nov 28, 2017 at 11:00 AM, Alan Cox <gnomes@lxorguk.ukuu.org.uk> wrote:
> >
> > The notation in question has been standard in tools like lint since the
> > end of the 1970s
>
> Yes.
>
> That said, maybe one option would be to annotate the "case:" and
> "default:" statements if that makes people happier.
>
> IOW, we could do something like
>
> #define fallthrough __atttibute__((fallthrough))
>
> and then write
>
> fallthrough case 1:
> ...
>
> which while absolutely not traditional, might look and read a bit more
> logical to people. I mean, it literally _is_ a "fallthrough case", so
> it makes semantic sense.
>
> Or maybe people hate that kind of "making up new syntax" too?
Fine with me. Better than any comment.
Thanks,
tglx
next prev parent reply other threads:[~2017-11-28 20:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 23:52 Gustavo A. R. Silva
2017-11-28 13:49 ` Thomas Gleixner
2017-11-28 18:05 ` Gustavo A. R. Silva
2017-11-28 18:10 ` Thomas Gleixner
2017-11-28 18:17 ` Thomas Gleixner
2017-11-28 18:22 ` Gustavo A. R. Silva
2017-11-28 18:27 ` Thomas Gleixner
2017-11-28 18:35 ` Thomas Gleixner
2017-11-28 18:45 ` Thomas Gleixner
2017-11-28 18:53 ` Gustavo A. R. Silva
2017-11-28 19:48 ` Thomas Gleixner
2017-11-28 19:00 ` Alan Cox
2017-11-28 19:10 ` Linus Torvalds
2017-11-28 19:59 ` Joe Perches
2017-11-28 20:08 ` Thomas Gleixner [this message]
2017-11-28 20:34 ` Kees Cook
2017-11-28 20:37 ` Gustavo A. R. Silva
2017-11-29 1:07 ` Joe Perches
2017-11-29 8:20 ` Geert Uytterhoeven
2017-11-28 20:11 ` Thomas Gleixner
2017-11-28 20:25 ` Gustavo A. R. Silva
2017-11-28 21:25 ` Thomas Gleixner
2017-11-29 15:10 ` Gustavo A. R. Silva
2017-11-29 15:14 ` Thomas Gleixner
2017-11-30 0:21 ` Kees Cook
2019-01-29 23:56 Gustavo A. R. Silva
2019-01-30 0:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711282108000.2222@nanos \
--to=tglx@linutronix.de \
--cc=garsilva@embeddedor.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®