From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752926AbdK3QA6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 11:00:58 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:45810 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752031AbdK3QA5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 11:00:57 -0500
Date: Thu, 30 Nov 2017 17:00:52 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
cc: X86 ML <x86@kernel.org>, Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86/power: Fix some ordering bugs in
 __restore_processor_context()
In-Reply-To: <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711301700260.1925@nanos>
References: <6b31721ea92f51ea839e79bd97ade4a75b1eeea2.1512057304.git.luto@kernel.org> <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 30 Nov 2017, Andy Lutomirski wrote:

> On Thu, Nov 30, 2017 at 7:57 AM, Andy Lutomirski <luto@kernel.org> wrote:
> > __restore_processor_context() had a couple of ordering bugs.  It
> > restored GSBASE after calling load_gs_index(), and the latter can
> > call into tracing code.  It also tried to restore segment registers
> > before restoring the LDT, which is straight-up wrong.
> 
> Ingo, Thomas, if you apply this version, can you fix up the following
> changelog bug:
> 
> >                 .seg_not_present = 1,
> 
> That should be = 0 above.

Sure. I'll wait for Jarkko to confirm.

> If I send a v2, I'll fix it.
>