From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbdLFMMn (ORCPT ); Wed, 6 Dec 2017 07:12:43 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50712 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdLFMMk (ORCPT ); Wed, 6 Dec 2017 07:12:40 -0500 X-IronPort-AV: E=Sophos;i="5.45,368,1508796000"; d="scan'208";a="304226173" Date: Wed, 6 Dec 2017 13:12:32 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() In-Reply-To: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> Message-ID: References: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/misc/emi26.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c > index 24d841850e05..654e93857d65 100644 > --- a/drivers/usb/misc/emi26.c > +++ b/drivers/usb/misc/emi26.c > @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, > int result; > unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); > > - if (!buffer) { > - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); I guess the length information would not be so easy to find in the backtrace. julia > + if (!buffer) > return -ENOMEM; > - } > + > /* Note: usb_control_msg returns negative value on error or length of the > * data that was written! */ > result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >