From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752102AbdLLRA4 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 12:00:56 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:33681 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750853AbdLLRAw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 12:00:52 -0500
Date: Tue, 12 Dec 2017 18:00:48 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linuxfoundation.org>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>,
        David Laight <David.Laight@aculab.com>,
        Kees Cook <keescook@chromium.org>
Subject: Re: [patch V2 2/2] x86/ldt: Prevent ldt inheritance on exec
In-Reply-To: <20171211121302.bdjkhnfv2ncclrht@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1712121800200.1794@nanos>
References: <20171208223241.367344665@linutronix.de> <20171208223421.711848352@linutronix.de> <alpine.DEB.2.20.1712091922340.2301@nanos> <20171211121302.bdjkhnfv2ncclrht@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 11 Dec 2017, Peter Zijlstra wrote:
> On Sat, Dec 09, 2017 at 07:24:35PM +0100, Thomas Gleixner wrote:
> > On Fri, 8 Dec 2017, Thomas Gleixner wrote:
> > > +int ldt_dup_context(struct mm_struct *old_mm, struct mm_struct *mm)
> > >  {
> > >  	struct ldt_struct *new_ldt;
> > > -	struct mm_struct *old_mm;
> > >  	int retval = 0;
> > >  
> > > -	mutex_init(&mm->context.lock);
> > > -	old_mm = current->mm;
> > > -	if (!old_mm) {
> > > -		mm->context.ldt = NULL;
> > > +	if (!old_mm)
> > >  		return 0;
> > > -	}
> > >  
> > >  	mutex_lock(&old_mm->context.lock);
> > 
> > Bah. That's broken. It now nests into old_mm->mmap_sem which is the reverse
> > lock order than in ldt_write. Will fix.
> 
> But read_ldt() will still nest mmap_sem inside context.lock, no? Lockdep
> doesn't care about old_mm vs new_mm.

Yeah, found that and fixed that already. Next version will be perfect :)