From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756854AbdLOQk3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 11:40:29 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:40430 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756697AbdLOQkY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 11:40:24 -0500
Date: Fri, 15 Dec 2017 17:40:15 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Biggers <ebiggers3@gmail.com>
cc: Dmitry Vyukov <dvyukov@google.com>, Greg KH <greg@kroah.com>,
        Kees Cook <keescook@chromium.org>,
        Alexey Dobriyan <adobriyan@gmail.com>, security@kernel.org,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        syzkaller-bugs@googlegroups.com,
        Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: general protection fault in show_timer
In-Reply-To: <20171214183607.GB259981@gmail.com>
Message-ID: <alpine.DEB.2.20.1712151735120.1702@nanos>
References: <CACVxJT-WEm8KbmSCmQ_EWMRVDcoBp0g-DJRg89CJzi5+sekymg@mail.gmail.com> <CACT4Y+aTcJq7hu+azvd37XD09F8-PAXz4hNgKqYzXFb_iZndKQ@mail.gmail.com> <CACT4Y+ZGPYH5spxW=R5jn7=JCCo-_nfWvQdQLW7iESO+Lpmf9A@mail.gmail.com> <CACVxJT9Q+-1xGkVmdz+e6869Few90E+D8fMQWeSpW=MA76_03A@mail.gmail.com>
 <alpine.DEB.2.20.1711301355450.1925@nanos> <CAGXu5j+92ZebfVQHKoH0M3OcrqUC++YFj8EYy=kW7iNaa4_aFQ@mail.gmail.com> <20171212083343.GG22935@kroah.com> <alpine.DEB.2.20.1712141525300.4998@nanos> <CACT4Y+Yu1csMLNa0P=RfEtWC+f0VbnX8Q8L63doWqRJU0c5KLA@mail.gmail.com>
 <alpine.DEB.2.20.1712141631470.4998@nanos> <20171214183607.GB259981@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 14 Dec 2017, Eric Biggers wrote:
> On Thu, Dec 14, 2017 at 04:34:12PM +0100, Thomas Gleixner wrote:
> > On Thu, 14 Dec 2017, Dmitry Vyukov wrote:
> > > On Thu, Dec 14, 2017 at 3:26 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > > On Tue, 12 Dec 2017, Greg KH wrote:
> > > >> Did this ever go anywhere?  I don't see it in Linus's tree yet...
> > > >
> > > > I learned yesterday that syzboz is understuffed and cannot test patches, so
> > > > I need to find a minute to run the reproducer myself and verify that the
> > > > patch is correct.
> > > 
> > > Hi Thomas,
> > > 
> > > Why do you say so? Have you tried to ask it to test?
> > > https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot
> > > What happened?
> > 
> > Eric explained that to me yesterday and I did not try yet. 
> > 
> 
> Your patch definitely fixes the bug (I tested the C reproducers, you just need
> to build a kernel with CONFIG_CHECKPOINT_RESTORE=y and CONFIG_POSIX_TIMERS=y,
> then run them).  The real question is whether the check being introduced is too
> strict -- are there users passing in other values for ->sigev_notify that would
> be broken?  That I can't really answer.

Me neither. The manpage is rather clear about the possible values, so I
don't expect wreckage. Aside of that non canonical values would have to
have bit 2, i.e. SIGEV_THREAD_ID cleared because that already has a
restriction that it's only allowed with SIGEV_SIGNAL. So unlikely...

If really some crap application breaks we can handle it in the default
clause by setting it to SIGEV_SIGNAL. Though I rather prefer not to do that
unless it turns out to be absolutely necessary.

Thanks,

	tglx