From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757052AbdLPUgz (ORCPT ); Sat, 16 Dec 2017 15:36:55 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:33001 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869AbdLPUgy (ORCPT ); Sat, 16 Dec 2017 15:36:54 -0500 X-IronPort-AV: E=Sophos;i="5.45,412,1508796000"; d="scan'208";a="248602969" Date: Sat, 16 Dec 2017 21:36:51 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Joe Perches , linux-pm@vger.kernel.org, Sebastian Reichel , LKML , kernel-janitors@vger.kernel.org Subject: Re: tps65090-charger: Delete an error message for a failed memory allocation in two functions In-Reply-To: <4beb0d2e-adf6-5eeb-43c7-7829d54c6656@users.sourceforge.net> Message-ID: References: <1513450432.4647.47.camel@perches.com> <4beb0d2e-adf6-5eeb-43c7-7829d54c6656@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Dec 2017, SF Markus Elfring wrote: > >> Omit an extra message for a memory allocation failure in these functions. > > > > Because??? > > > > Fix your commit message. > > > > Say _WHY_ should this be applied. > > I am still waiting for possibilities to improve also the corresponding > reference documentation somehow as you know it already. If you require someone else to update the documentation to be able to explain why the patch is useful, then it would seem that you do not know why the patch is useful, and thus should not submit it. julia > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >