From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbdLUK15 (ORCPT ); Thu, 21 Dec 2017 05:27:57 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:54483 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbdLUK1z (ORCPT ); Thu, 21 Dec 2017 05:27:55 -0500 Date: Thu, 21 Dec 2017 11:27:52 +0100 (CET) From: Thomas Gleixner To: Kees Cook cc: Linus Torvalds , linux-kernel@vger.kernel.org, "Tobin C. Harding" , x86@kernel.org Subject: Re: [PATCH] Do not hash userspace addresses in fault handlers In-Reply-To: <20171219215223.GA21997@beast> Message-ID: References: <20171219215223.GA21997@beast> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Dec 2017, Kees Cook wrote: > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index febf6980e653..06fe3d51d385 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -860,7 +860,7 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code, > if (!printk_ratelimit()) > return; > > - printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx", > + printk("%s%s[%d]: segfault at %lx ip %px sp %px error %lx", > task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG, > tsk->comm, task_pid_nr(tsk), address, > (void *)regs->ip, (void *)regs->sp, error_code); For that part: Reviewed-by: Thomas Gleixner