From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbdLZSKx (ORCPT ); Tue, 26 Dec 2017 13:10:53 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:21406 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbdLZSKu (ORCPT ); Tue, 26 Dec 2017 13:10:50 -0500 X-IronPort-AV: E=Sophos;i="5.45,461,1508796000"; d="scan'208";a="306934448" Date: Tue, 26 Dec 2017 19:10:48 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Dmitry Torokhov , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 0/1] Input: inline macros for MODULE_LICENSE, etc In-Reply-To: <1514311471.3468.8.camel@perches.com> Message-ID: References: <1514307905-3486-1-git-send-email-Julia.Lawall@lip6.fr> <1514311471.3468.8.camel@perches.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Dec 2017, Joe Perches wrote: > On Tue, 2017-12-26 at 18:05 +0100, Julia Lawall wrote: > > Inline macro for MODULE_LICENSE to make the license information easy to > > find, eg with grep. Inline the other module-related macros at the same > > time. > > Perhaps it'd be better to not make this > dependent on a MODULE_LICENSE use, but allow > any #define foo/#define MODULE_ foo > where foo is used once to be converted. Well, I wanted something that could be checked in a finite (small) amount of time... There seemed to be a slightly more compelling argument for inlining the license, so I decided to focus on that. What you suggested resulted in around 5000 lines of patch code, mostly inlining authors and descriptions. But maybe you have already done the things done in my patch and it hasn't been picked up yet? julia