From: Thomas Gleixner <tglx@linutronix.de>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Jakub Kicinski <kubakici@wp.pl>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux/master crashes on boot with KASAN=y
Date: Wed, 27 Dec 2017 19:09:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1712271909050.2431@nanos> (raw)
In-Reply-To: <c13159f0-74d0-bab7-43e7-78434ead75c9@virtuozzo.com>
On Tue, 26 Dec 2017, Andrey Ryabinin wrote:
> On 12/24/2017 04:48 AM, Andy Lutomirski wrote:
> > Could this be #define MODULES_END KASAN_ROUND_DOWN(__fix_to_virt(...)) instead?
> >
> Actually, we could simply set fixed MODULES_END, as it was before
> f06bdd4001c2 ("x86/mm: Adapt MODULES_END based on fixmap section size").
> AFAICS, the whole point of f06bdd4001c2 was to move MODULES_END down if
> NR_CPUS is big. But since 92a0f81d8957 ("x86/cpu_entry_area: Move it out
> of the fixmap") cpu_entry_area is not in fixmap anymore. So it should be
> fine to set fixed MODULES_END.
>
> The only concern I have is 4.14 stable, where 21506525f ("x86/kasan/64:
> Teach KASAN about the cpu_entry_area") was backported. Is 92a0f81d8957
> ("x86/cpu_entry_area: Move it out of the fixmap") also a candidate for
> stable?
>
> If so, fixed MODULES_END seems like a better choice.
Yes, it's on the way there.
Thanks,
tglx
next prev parent reply other threads:[~2017-12-27 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 8:01 Jakub Kicinski
2017-12-23 8:19 ` Jakub Kicinski
2017-12-23 12:41 ` Andrey Ryabinin
2017-12-24 1:22 ` Jakub Kicinski
2017-12-24 1:48 ` Andy Lutomirski
2017-12-26 11:47 ` Andrey Ryabinin
2017-12-27 18:09 ` Thomas Gleixner [this message]
2017-12-28 16:06 ` [PATCH] x86/mm: Set MODULES_END to 0xffffffffff000000 Andrey Ryabinin
2018-01-04 22:09 ` [tip:x86/pti] " tip-bot for Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712271909050.2431@nanos \
--to=tglx@linutronix.de \
--cc=aryabinin@virtuozzo.com \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®