mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Borislav Petkov <bp@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: use HPET in 64-bit mode to avoid a harware 32-bit wraparound bug
Date: Thu, 28 Dec 2017 12:49:22 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712281243110.1688@nanos> (raw)
In-Reply-To: <20171208171700.pbridtbt3tkvjbhi@dwarf.suse.cz>

On Fri, 8 Dec 2017, Jiri Bohac wrote:

> This patch changes the HPET clockevent code to use the Timer 0 in 64-bit
> mode (if compiled for x86_64; doing this for 32-bit kernels would bring
> a performance penalty as a single read would require three 32-bit HPET
> accesses).

We tried that before and 64bit mode did not work on all tested platforms.

Aside of that your patch is broken because it does not check whether HPET
actually supports 64bit mode at all. The COUNT_SIZE_CAP bit is there for a
reason.

Thanks,

	tglx

      reply	other threads:[~2017-12-28 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 17:17 Jiri Bohac
2017-12-28 11:49 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712281243110.1688@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jbohac@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®