From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org
Subject: Re: PTI build regression with nvidia drivers
Date: Thu, 4 Jan 2018 19:25:22 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801041923440.2127@nanos> (raw)
In-Reply-To: <CAGXu5jLM6NXoP9dCAiYDKUaGzSGp7WAY3PpUq-2osL4WLQg2Dg@mail.gmail.com>
On Thu, 4 Jan 2018, Kees Cook wrote:
>
> This was pointed out in a few places, but not forwarded to lkml yet that I saw:
>
> https://devtalk.nvidia.com/default/topic/1028222/linux/lts-kernel-patch-for-intel-cpu-vulnerability-breaks-nvidia-driver/post/5230546
>
> Before and after PTI, cpu_tlbstate is a GPL export:
>
> $ git show v4.14:arch/x86/mm/init.c | grep cpu_tlbstate
> DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = {
> EXPORT_SYMBOL_GPL(cpu_tlbstate);
>
> But after PTI, inlining or something is dragging cpu_tlbstate into the
> open, causing build failures.
>
> Technically, to avoid regressions for that module, we'll need to drop
> the GPL marking on that symbol, or find some other solution...
Correct. It's indirect via the tlbflush inlines. We'll fix it as usual. Sigh....
Thanks,
tglx
prev parent reply other threads:[~2018-01-04 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 18:17 Kees Cook
2018-01-04 18:25 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801041923440.2127@nanos \
--to=tglx@linutronix.de \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®