From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756285AbeAJBFX (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 20:05:23 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:53891 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756206AbeAJBFU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 20:05:20 -0500
Date: Wed, 10 Jan 2018 02:05:16 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
cc: Linus Torvalds <torvalds@linux-foundation.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Paul Turner <pjt@google.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Jiri Kosina <jikos@kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86/retpoline: Fix NOSPEC_JMP for tip
In-Reply-To: <20180110005113.h7ya6fl6shccvzew@two.firstfloor.org>
Message-ID: <alpine.DEB.2.20.1801100203450.2200@nanos>
References: <20180110003139.10531-1-andi@firstfloor.org> <CA+55aFzyVFEUKaLpqxfwh5E9QFgMjzr+wVoYGxqTHVDkGcFkOw@mail.gmail.com> <20180110005113.h7ya6fl6shccvzew@two.firstfloor.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, 9 Jan 2018, Andi Kleen wrote:

> > Then just make sure X86_FEATURE_RETPOLINE_AMD disables X86_FEATURE_RETPOLINE.
> > 
> > That is both simpler an dsmaller, no?
> 
> Yes that works, and is clearly better/simpler.
> 
> Tested-by: Andi Kleen <ak@linux.intel.com>
> 
> Thomas, I assume you will fix it up, or let me know if I should
> send another patch.

I'd appreciate a patch as I'm almost falling asleep. Can you please have a
look at the usage sites of the feature bits as well?

Thanks,

	tglx