From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753301AbeANVBt (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sun, 14 Jan 2018 16:01:49 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:38517 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752581AbeANVBs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 14 Jan 2018 16:01:48 -0500
Date: Sun, 14 Jan 2018 22:01:44 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: David Woodhouse <dwmw@amazon.co.uk>,
        LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [GIT pull] x86/pti updates for 4.15
In-Reply-To: <CA+55aFzWgquv4i6Mab6bASqYXg3ErV3XDFEYf=GEcCDQg5uAtw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1801142201050.2371@nanos>
References: <alpine.DEB.2.20.1801141550270.2371@nanos> <CA+55aFzWgquv4i6Mab6bASqYXg3ErV3XDFEYf=GEcCDQg5uAtw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Sun, 14 Jan 2018, Linus Torvalds wrote:
> On Sun, Jan 14, 2018 at 7:27 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-pti-for-linus
> 
> So I do think this:
> 
>         $(warning CONFIG_RETPOLINE=y, but not supported by the
> compiler. Toolchain update recommended.)
> 
> needs to be removed.
> 
> Yes, yes, I understand why it's warning. It's still both annoying and wrong.
> 
> It's wrong because it will just make people turn off RETPOLINE, and
> the asm updates - and return stack clearing - that are independent of
> the compiler are likely the most important parts because they are
> likely the ones easiest to target.
> 
> And it's annoying because most people won't be able to do anything
> about it. The number of people building their own compiler? Very
> small. So if their distro hasn't got a compiler yet (and pretty much
> nobody does), the warning is just annoying crap.
> 
> It is already properly reported as part of the sysfs interface. The
> compile-time warning only encourages bad things.

Good point. I'll queue a patch to that effect or do you just want to do
that yourself?

Thanks,

	tglx